Java Mailing List Archive

http://www.ant-tasks.com/

Home » Ant Developers List »

Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

Stefan Bodewig

2010-02-01

Replies: Find Java Web Hosting

Author LoginPost Reply
On 2010-01-30, N C <nc1500@(protected):

> In Revision 793462, a BufferedWriter was added to
> JUnitTestRunner.filterStack(String).

Prior to that there was a PrintWriter instead of the BufferedWriter and
it was replaced here like in several other classes.

> However, the BufferedWriter was not flushed before returning the
> underlying StringWriter's contents. This may exclude all or part of
> the filtered stack trace from the returned String.

Good catch. The PrintWriter wasn't closed before the change either and
since I only changed the writer implementation the buffering now caused
a loss of data.

I'll revisit the remaining classes I have changed to ensure they close
the writers now if they didn't do so before.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@(protected)
For additional commands, e-mail: dev-help@(protected)

©2008 ant-tasks.com - Jax Systems, LLC, U.S.A.