Java Mailing List Archive

http://www.ant-tasks.com/

Home » Ant Developers List »

Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

Stefan Bodewig

2010-02-01

Replies: Find Java Web Hosting

Author LoginPost Reply
On 2010-02-01, Stefan Bodewig <bodewig@(protected):

> I'll revisit the remaining classes I have changed to ensure they close
> the writers now if they didn't do so before.

I've identified a few cases where the writer wouldn't get flushed or
closed in the error case - but things should be fine with the revision
tagged for 1.8.0 for the normal no-error case. I'm not sure it is
important that the broken result of a sent email message is complete if
it is broken anyway.

Anyway, while revisiting all classes that use BufferedWriter I've added
a few finally blocks and changed a few handmade "if != null close"
blocks with FileUtils, no real issues.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@(protected)
For additional commands, e-mail: dev-help@(protected)

©2008 ant-tasks.com - Jax Systems, LLC, U.S.A.