Java Mailing List Archive

http://www.ant-tasks.com/

Home » Ant Developers List »

Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

Stefan Bodewig

2010-02-01

Replies: Find Java Web Hosting

Author LoginPost Reply
On 2010-02-01, N C <nc1500@(protected):

> --- On Mon, 2/1/10, Stefan Bodewig <bodewig@(protected):

>> I'll revisit the remaining classes I have changed to ensure
>> they close the writers now if they didn't do so before.

> If you haven't, you might want to take a look at
> PlainJUnitResultFormatter. It isn't clear to me that the
> BufferedWriter "wri" is properly flushed under exceptional conditions,
> but I don't know the code well enough.

This was one of several places where I changed the code in the error
case. Here like in other places the stream wouldn't get flushed if an
exception occured while writing - but the flush will most likely not
succeed in this case anyway, so the change won't have much of an impact.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@(protected)
For additional commands, e-mail: dev-help@(protected)

©2008 ant-tasks.com - Jax Systems, LLC, U.S.A.